zephyr

Commit Graph

Author	SHA1	Message	Date
Gerard Marull-Paretas	acc8cb4bc8	include: add missing irq.h include Some modules use the IRQ API without including the necessary headers. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>	3 years ago
Henrik Brix Andersen	9c71615f83	drivers: gpio: check if clock device is ready before accessing Add check for device_is_ready() before accessing clock control devices. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>	3 years ago
Simon Hein	d0921018fc	drivers: Fix coding guidelines MISRAC:2012 Rule 14.4 do-whiles/Zero checks MISRA C:2012 Rule 14.4 (The controlling expression of an if statement and the controlling expression of an iteration-statement shall have essentially Boolean type.) Use `do { ... } while (false)' instead of `do { ... } while (0)'. Use comparisons with zero instead of implicitly testing integers. The commit is a subset of the original auditable-branch commit: `5d02614e34` Signed-off-by: Simon Hein <SHein@baumer.com>	3 years ago
Anas Nashif	49b36ead95	drivers: add mising braces to single line if statements Following zephyr's style guideline, all if statements, including single line statements shall have braces. Signed-off-by: Anas Nashif <anas.nashif@intel.com>	3 years ago
Kumar Gala	93f2fedc12	drivers: gpio: lpc11u6x: Remove DT_LABEL usage Remove DT_LABEL usage that is needed for device_get_binding, replace this with DEVICE_DT_GET. Signed-off-by: Kumar Gala <galak@kernel.org>	3 years ago
Daniel DeGrasse	81c209dc2d	drivers: gpio_lpc11u6x: use pio nodes to configure pin mux for gpio switch gpio driver to use pio nodes to configure pin control settings, and stop using pinmux driver within gpio driver. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>	3 years ago
Gerard Marull-Paretas	fb60aab245	drivers: migrate includes to <zephyr/...> In order to bring consistency in-tree, migrate all drivers to the new prefix <zephyr/...>. Note that the conversion has been scripted, refer to #45388 for more details. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>	3 years ago
Nazar Kazakov	9713f0d47c	everywhere: fix typos Fix a lot of typos Signed-off-by: Nazar Kazakov <nazar.kazakov.work@gmail.com>	3 years ago
Gerard Marull-Paretas	ae5ebe8e51	drivers: gpio: drop DEV_DATA/DEV_CFG usage Stop using redundant DEV_DATA/DEV_CFG macros and use dev->data and dev->config instead. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>	4 years ago
Ryan McClelland	ecf99abc17	drivers: gpio: set all on-chip gpios to PRE_KERNEL_1/2 init PRE_KERNEL_1 is to be used for devices that have no dependencies and do not use kernel features, such as those that rely solely on hardware present in the processor/SOC. This commit updates these gpios to initialize during the PRE_KERNEL_1 rather than the POST_KERNEL. Some SoC drivers are moved to PRE_KERNEL_2 due to dependencies. A lot of 'other' drivers can depend on GPIOs though phandles (such as reset lines, data or command gpios, etc...). Most of these drivers that would need this would come up on the POST_KERNEL, and it's likely the driver may not be up yet as it should be defined. Signed-off-by: Ryan McClelland <ryanmcclelland@fb.com>	4 years ago
Maureen Helm	836651b453	drivers: gpio: Refactor drivers to use shared init priority Refactors all of the on-chip GPIO drivers to use a shared driver class initialization priority configuration, CONFIG_GPIO_INIT_PRIORITY, to allow configuring GPIO drivers separately from other devices. This is similar to other driver classes like I2C and SPI. Most drivers previously used CONFIG_KERNEL_INIT_PRIORITY_DEFAULT or CONFIG_KERNEL_INIT_PRIORITY_DEVICE, therefore the default for this new option is the lower of the two, which means earlier initialization. Driver-specific options for off-chip I2C- or SPI-based GPIO drivers are left intact because they often need to be initialized at a different priority than on-chip GPIO drivers. Signed-off-by: Maureen Helm <maureen.helm@intel.com>	4 years ago
Gerard Marull-Paretas	1b5542056b	drivers: gpio: remove usage of device_pm_control_nop device_pm_control_nop is now deprecated in favour of NULL. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>	4 years ago
Kumar Gala	02703e60d9	device: Remove DEVICE_DT_DECLARE / DEVICE_DT_INST_DECLARE Now that we generate a header that extern's all possible devicetree based device struct we can remove DEVICE_DT_DECLARE and DEVICE_DT_INST_DECLARE as they aren't needed anymore. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Kumar Gala	569155701c	drivers: gpio: Convert drivers to new DT device macros Convert gpio drivers to use new DT variants of the DEVICE APIs. DEVICE_AND_API_INIT -> DEVICE_DT_DEFINE DEVICE_GET -> DEVICE_DT_GET DEVICE_DECLARE -> DEVICE_DT_INST_DECLARE etc.. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Tomasz Bursztyka	4dcfb5531c	isr: Normalize usage of device instance through ISR The goal of this patch is to replace the 'void ' parameter by 'struct device ' if they use such variable or just 'const void ' on all relevant ISRs This will avoid not-so-nice const qualifier tweaks when device instances will be constant. Note that only the ISR passed to IRQ_CONNECT are of interest here. In order to do so, the script fix_isr.py below is necessary: from pathlib import Path import subprocess import pickle import mmap import sys import re import os cocci_template = """ @r_fix_isr_0 @ type ret_type; identifier P; identifier D; @@ -ret_type <!fn!>(void P) +ret_type <!fn!>(const struct device P) { ... ( const struct device D = (const struct device )P; \| const struct device D = P; ) ... } @r_fix_isr_1 @ type ret_type; identifier P; identifier D; @@ -ret_type <!fn!>(void P) +ret_type <!fn!>(const struct device P) { ... const struct device D; ... ( D = (const struct device )P; \| D = P; ) ... } @r_fix_isr_2 @ type ret_type; identifier A; @@ -ret_type <!fn!>(void A) +ret_type <!fn!>(const void A) { ... } @r_fix_isr_3 @ const struct device D; @@ -<!fn!>((void )D); +<!fn!>(D); @r_fix_isr_4 @ type ret_type; identifier D; identifier P; @@ -ret_type <!fn!>(const struct device P) +ret_type <!fn!>(const struct device D) { ... ( -const struct device D = (const struct device )P; \| -const struct device D = P; ) ... } @r_fix_isr_5 @ type ret_type; identifier D; identifier P; @@ -ret_type <!fn!>(const struct device P) +ret_type <!fn!>(const struct device D) { ... -const struct device D; ... ( -D = (const struct device *)P; \| -D = P; ) ... } """ def find_isr(fn): db = [] data = None start = 0 try: with open(fn, 'r+') as f: data = str(mmap.mmap(f.fileno(), 0).read()) except Exception as e: return db while True: isr = "" irq = data.find('IRQ_CONNECT', start) while irq > -1: p = 1 arg = 1 p_o = data.find('(', irq) if p_o < 0: irq = -1 break; pos = p_o + 1 while p > 0: if data[pos] == ')': p -= 1 elif data[pos] == '(': p += 1 elif data[pos] == ',' and p == 1: arg += 1 if arg == 3: isr += data[pos] pos += 1 isr = isr.strip(',\\n\\t ') if isr not in db and len(isr) > 0: db.append(isr) start = pos break if irq < 0: break return db def patch_isr(fn, isr_list): if len(isr_list) <= 0: return for isr in isr_list: tmplt = cocci_template.replace('<!fn!>', isr) with open('/tmp/isr_fix.cocci', 'w') as f: f.write(tmplt) cmd = ['spatch', '--sp-file', '/tmp/isr_fix.cocci', '--in-place', fn] subprocess.run(cmd) def process_files(path): if path.is_file() and path.suffix in ['.h', '.c']: p = str(path.parent) + '/' + path.name isr_list = find_isr(p) patch_isr(p, isr_list) elif path.is_dir(): for p in path.iterdir(): process_files(p) if len(sys.argv) < 2: print("You need to provide a dir/file path") sys.exit(1) process_files(Path(sys.argv[1])) And is run: ./fix_isr.py <zephyr root directory> Finally, some files needed manual fixes such. Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	e18fcbba5a	device: Const-ify all device driver instance pointers Now that device_api attribute is unmodified at runtime, as well as all the other attributes, it is possible to switch all device driver instance to be constant. A coccinelle rule is used for this: @r_const_dev_1 disable optional_qualifier @ @@ -struct device * +const struct device * @r_const_dev_2 disable optional_qualifier @ @@ -struct device * const +const struct device * Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	98d9b01322	device: Apply driver_api/data attributes rename everywhere Via coccinelle: @r_device_driver_api_and_data_1@ struct device *D; @@ ( D-> - driver_api + api \| D-> - driver_data + data ) @r_device_driver_api_and_data_2@ expression E; @@ ( net_if_get_device(E)-> - driver_api + api \| net_if_get_device(E)-> - driver_data + data ) And grep/sed rules for macros: git grep -rlz 'dev)->driver_data' \| xargs -0 sed -i 's/dev)->driver_data/dev)->data/g' git grep -rlz 'dev->driver_data' \| xargs -0 sed -i 's/dev->driver_data/dev->data/g' git grep -rlz 'device->driver_data' \| xargs -0 sed -i 's/device->driver_data/device->data/g' Fixes #27397 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	af6140cc0d	device: Apply config_info rename everywhere Via coccinelle: @r_device_config@ struct device *D; @@ D-> - config_info + config And 2 grep/sed rules for macros: git grep -rlz 'dev)->config_info' \| xargs -0 sed -i 's/dev)->config_info/dev)->config/g' git grep -rlz 'dev->config_info' \| xargs -0 sed -i 's/dev->config_info/dev->config/g' Fixes #27397 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Simon Guinot	d3dd297619	drivers: gpio: add driver for NXP LPC11U6X MCUs This patch adds a GPIO driver allowing to configure the GPIOs found on the LPC11U6x MCUs. Signed-off-by: Simon Guinot <simon.guinot@seagate.com>	5 years ago

19 Commits (acc8cb4bc8369f9c9f0ac59bcf2912f51a25db7e)