zephyr

Commit Graph

Author	SHA1	Message	Date
Yong Cong Sin	7248efcd59	drivers: intc: update to use multi-level API Update these multi-level interrupt drivers to use the new API. Signed-off-by: Yong Cong Sin <ycsin@meta.com>	1 year ago
Gerard Marull-Paretas	178bdc4afc	include: add missing zephyr/irq.h include Change automated searching for files using "IRQ_CONNECT()" API not including <zephyr/irq.h>. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>	3 years ago
Gerard Marull-Paretas	fb60aab245	drivers: migrate includes to <zephyr/...> In order to bring consistency in-tree, migrate all drivers to the new prefix <zephyr/...>. Note that the conversion has been scripted, refer to #45388 for more details. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>	3 years ago
Daniel Leung	40138c96b2	interrupt_controller: dw: use finalstatus instead of maskstatus Instead of using maskstatus to see if an interrupt has fired, use finalstatus instead. It has been observed that some controllers do not update maskstatus correctly with incoming interrupts, but finalstatus works fine. FYI, the DW driver in Linux is also using finalstatus. Signed-off-by: Daniel Leung <daniel.leung@intel.com>	4 years ago
Gerard Marull-Paretas	e6170a4dbc	drivers: interrupt_controller: remove usage of device_pm_control_nop device_pm_control_nop is now deprecated in favour of NULL. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>	4 years ago
Kumar Gala	2d754333ad	drivers: interrupt_controller: Convert drivers to new DT device macros Convert interrupt_controller drivers from: DEVICE_AND_API_INIT -> DEVICE_DT_INST_DEFINE DEVICE_GET -> DEVICE_DT_INST_GET DEVICE_DECLARE -> DEVICE_DT_INST_DECLARE etc... Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Tomasz Bursztyka	4dcfb5531c	isr: Normalize usage of device instance through ISR The goal of this patch is to replace the 'void ' parameter by 'struct device ' if they use such variable or just 'const void ' on all relevant ISRs This will avoid not-so-nice const qualifier tweaks when device instances will be constant. Note that only the ISR passed to IRQ_CONNECT are of interest here. In order to do so, the script fix_isr.py below is necessary: from pathlib import Path import subprocess import pickle import mmap import sys import re import os cocci_template = """ @r_fix_isr_0 @ type ret_type; identifier P; identifier D; @@ -ret_type <!fn!>(void P) +ret_type <!fn!>(const struct device P) { ... ( const struct device D = (const struct device )P; \| const struct device D = P; ) ... } @r_fix_isr_1 @ type ret_type; identifier P; identifier D; @@ -ret_type <!fn!>(void P) +ret_type <!fn!>(const struct device P) { ... const struct device D; ... ( D = (const struct device )P; \| D = P; ) ... } @r_fix_isr_2 @ type ret_type; identifier A; @@ -ret_type <!fn!>(void A) +ret_type <!fn!>(const void A) { ... } @r_fix_isr_3 @ const struct device D; @@ -<!fn!>((void )D); +<!fn!>(D); @r_fix_isr_4 @ type ret_type; identifier D; identifier P; @@ -ret_type <!fn!>(const struct device P) +ret_type <!fn!>(const struct device D) { ... ( -const struct device D = (const struct device )P; \| -const struct device D = P; ) ... } @r_fix_isr_5 @ type ret_type; identifier D; identifier P; @@ -ret_type <!fn!>(const struct device P) +ret_type <!fn!>(const struct device D) { ... -const struct device D; ... ( -D = (const struct device *)P; \| -D = P; ) ... } """ def find_isr(fn): db = [] data = None start = 0 try: with open(fn, 'r+') as f: data = str(mmap.mmap(f.fileno(), 0).read()) except Exception as e: return db while True: isr = "" irq = data.find('IRQ_CONNECT', start) while irq > -1: p = 1 arg = 1 p_o = data.find('(', irq) if p_o < 0: irq = -1 break; pos = p_o + 1 while p > 0: if data[pos] == ')': p -= 1 elif data[pos] == '(': p += 1 elif data[pos] == ',' and p == 1: arg += 1 if arg == 3: isr += data[pos] pos += 1 isr = isr.strip(',\\n\\t ') if isr not in db and len(isr) > 0: db.append(isr) start = pos break if irq < 0: break return db def patch_isr(fn, isr_list): if len(isr_list) <= 0: return for isr in isr_list: tmplt = cocci_template.replace('<!fn!>', isr) with open('/tmp/isr_fix.cocci', 'w') as f: f.write(tmplt) cmd = ['spatch', '--sp-file', '/tmp/isr_fix.cocci', '--in-place', fn] subprocess.run(cmd) def process_files(path): if path.is_file() and path.suffix in ['.h', '.c']: p = str(path.parent) + '/' + path.name isr_list = find_isr(p) patch_isr(p, isr_list) elif path.is_dir(): for p in path.iterdir(): process_files(p) if len(sys.argv) < 2: print("You need to provide a dir/file path") sys.exit(1) process_files(Path(sys.argv[1])) And is run: ./fix_isr.py <zephyr root directory> Finally, some files needed manual fixes such. Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	e18fcbba5a	device: Const-ify all device driver instance pointers Now that device_api attribute is unmodified at runtime, as well as all the other attributes, it is possible to switch all device driver instance to be constant. A coccinelle rule is used for this: @r_const_dev_1 disable optional_qualifier @ @@ -struct device * +const struct device * @r_const_dev_2 disable optional_qualifier @ @@ -struct device * const +const struct device * Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	af6140cc0d	device: Apply config_info rename everywhere Via coccinelle: @r_device_config@ struct device *D; @@ D-> - config_info + config And 2 grep/sed rules for macros: git grep -rlz 'dev)->config_info' \| xargs -0 sed -i 's/dev)->config_info/dev)->config/g' git grep -rlz 'dev->config_info' \| xargs -0 sed -i 's/dev->config_info/dev->config/g' Fixes #27397 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Kumar Gala	a1b77fd589	zephyr: replace zephyr integer types with C99 types git grep -l 'u\(8\\|16\\|32\\|64\)_t' \| \ xargs sed -i "s/u\(8\\|16\\|32\\|64\)_t/uint\1_t/g" git grep -l 's\(8\\|16\\|32\\|64\)_t' \| \ xargs sed -i "s/s\(8\\|16\\|32\\|64\)_t/int\1_t/g" Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Tomasz Bursztyka	97326c0445	device: Fix structure attributes access Since struct devconfig was merged earlier into struct device, let's fix accessing config_info, name, ... attributes everywhere via: grep -rlZ 'dev->config->' \| xargs -0 sed -i 's/dev->config->/dev->/g' Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Kumar Gala	f74ddd3f6d	drivers: interrupt_controller: intc_dw: Convert to new DT_INST macros Convert older DT_INST_ macro use the new include/devicetree.h DT_INST macro APIs. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Daniel Leung	b4a7eed82e	interrupt_controller/dw_ictl: need to be initialized earlier The dw_ictl interrupt controller is an interrupt aggregator supporting multi-level interrupts. Therefore, it needs to be initialized earlier than any downstream interrupt controllers and devices. Signed-off-by: Daniel Leung <daniel.leung@intel.com>	5 years ago
Kumar Gala	e2d71c9c77	driver: interrupt_controller: dw: convert to DT_INST defines Convert driver to use DT_INST_ defines. The preferred defines for drivers are DT_INST_. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Daniel Leung	55afe00195	interrupt_controller: dw: fix base address not defined in config During driver rewrite, the field to specify the base address of the interrupt controller was dropped, which results in error in device initialization due to accessing random address (or null). Fix it by specifying the base address. Signed-off-by: Daniel Leung <daniel.leung@intel.com>	5 years ago
Anas Nashif	aa14022c8a	intel_s1000: various fixes for build errors Lot of misdefined variables that went in undetected due to lack of CI on this board. Fix them and test build with new SDK. Signed-off-by: Anas Nashif <anas.nashif@intel.com>	6 years ago
Tomasz Bursztyka	8d10e66371	drivers/interrupt-controller: Make irqs DT configured in DW DesignWare driver can manage different amount of irqs so let's make it configurable via DTS. Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	6 years ago
Tomasz Bursztyka	251141567f	drivers/interrupt_controller: No need for runtime base address in DW Base address does not change at runtime, thus storing it directly into device's config. Also keeping it consistent in naming: s/port/dev And no need to store irq_num as it is unused. Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	6 years ago
Tomasz Bursztyka	4b94668f5b	drivers/interrupt_controller: Normalize DT aliases consitently for DW DT_<domain>_DW_<num>_<option> as for SPI, GPIO, DMA etc... Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	6 years ago
Tomasz Bursztyka	c30600d4ab	drivers/interrupt_controller: Adopt file naming as other drivers Pattern being <domain>_<model>.<c/h>. Here interrupt_controller as a domain would be far too long so shortening it to "intc", as DTS does actually. Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	6 years ago
Daniel Leung	635aadc9a9	drivers/interrupt_controller: dw_ictl: add get_line_state() This implements the new API to query whether a particular IRQ line is enabled. Signed-off-by: Daniel Leung <daniel.leung@intel.com>	6 years ago
Patrik Flykt	8ff96b5a57	drivers: Add 'U' to unsigned variable assignments Add 'U' to a value when assigning it to an unsigned variable. MISRA-C rule 7.2 Signed-off-by: Patrik Flykt <patrik.flykt@intel.com>	7 years ago
Andrzej Głąbek	20202902f2	dts_fixups: Use DT_ prefix in all defined labels not related to Kconfig These changes were obtained by running a script created by Ulf Magnusson <Ulf.Magnusson@nordicsemi.no> for the following specification: 1. Read the contents of all dts_fixup.h files in Zephyr 2. Check the left-hand side of the #define macros (i.e. the X in #define X Y) 3. Check if that name is also the name of a Kconfig option 3.a If it is, then do nothing 3.b If it is not, then replace CONFIG_ with DT_ or add DT_ if it has neither of these two prefixes 4. Replace the use of the changed #define in the code itself (.c, .h, .ld) Additionally, some tweaks had to be added to this script to catch some of the macros used in the code in a parameterized form, e.g.: - CONFIG_GPIO_STM32_GPIO##__SUFFIX##_BASE_ADDRESS - CONFIG_UART_##idx##_TX_PIN - I2C_SBCON_##_num##_BASE_ADDR and to prevent adding DT_ prefix to the following symbols: - FLASH_START - FLASH_SIZE - SRAM_START - SRAM_SIZE - _ROM_ADDR - _ROM_SIZE - _RAM_ADDR - _RAM_SIZE which are surprisingly also defined in some dts_fixup.h files. Finally, some manual corrections had to be done as well: - name##_IRQ -> DT_##name##_IRQ in uart_stm32.c Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>	7 years ago
Anas Nashif	238b664a89	intel_s1000: include soc.h where needed We still need defines from soc.h for some of the drivers. Signed-off-by: Anas Nashif <anas.nashif@intel.com>	7 years ago
Kumar Gala	aa2bdbe322	drivers: Remove board.h include We either don't need board.h in the driver or we should be include soc.h instead. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	7 years ago
Rajavardhan Gundi	e3f2fa4f89	drivers: interrupts: introduce Designware interrupt controller This interrupt controller is a designware IP that combines several sources of interrupt into one line that is then routed to the parent controller. This implementation supports only the regular irqs with no support for priority filtering and vectored interrupts. Firqs are also not supported. Change-Id: I8bdf6f8df4632b6d7e8a3ba9a77116771d034a48 Signed-off-by: Rajavardhan Gundi <rajavardhan.gundi@intel.com> Signed-off-by: Anas Nashif <anas.nashif@intel.com>	7 years ago

20 Commits (main)