Browse Source

posix: use sys_clock implementation

Use the newly added sys_clock API in lib/os for

* clock_gettime()
* clock_settime()
* clock_nanosleep() and nanosleep()
* gettimeofday()

Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
pull/91872/head
Chris Friedt 2 months ago committed by Benjamin Cabé
parent
commit
8743da2f32
  1. 7
      include/zephyr/posix/time.h
  2. 7
      lib/posix/options/CMakeLists.txt
  3. 44
      lib/posix/options/clock.c
  4. 204
      lib/posix/options/clock_common.c
  5. 21
      lib/posix/options/clock_selection.c
  6. 4
      lib/posix/options/posix_clock.h
  7. 10
      lib/posix/options/xsi_single_process.c

7
include/zephyr/posix/time.h

@ -60,13 +60,14 @@ struct itimerspec { @@ -60,13 +60,14 @@ struct itimerspec {
#include <errno.h>
#include <zephyr/posix/posix_types.h>
#include <zephyr/posix/signal.h>
#include <zephyr/sys/clock.h>
#ifdef __cplusplus
extern "C" {
#endif
#ifndef CLOCK_REALTIME
#define CLOCK_REALTIME 1
#define CLOCK_REALTIME SYS_CLOCK_REALTIME
#endif
#ifndef CLOCK_PROCESS_CPUTIME_ID
@ -78,11 +79,11 @@ extern "C" { @@ -78,11 +79,11 @@ extern "C" {
#endif
#ifndef CLOCK_MONOTONIC
#define CLOCK_MONOTONIC 4
#define CLOCK_MONOTONIC SYS_CLOCK_MONOTONIC
#endif
#ifndef TIMER_ABSTIME
#define TIMER_ABSTIME 4
#define TIMER_ABSTIME SYS_TIMER_ABSTIME
#endif
int clock_gettime(clockid_t clock_id, struct timespec *ts);

7
lib/posix/options/CMakeLists.txt

@ -47,10 +47,7 @@ if (NOT CONFIG_TC_PROVIDES_POSIX_BARRIERS) @@ -47,10 +47,7 @@ if (NOT CONFIG_TC_PROVIDES_POSIX_BARRIERS)
endif()
if (NOT CONFIG_TC_PROVIDES_POSIX_CLOCK_SELECTION)
zephyr_library_sources_ifdef(CONFIG_POSIX_CLOCK_SELECTION
clock_common.c
clock_selection.c
)
zephyr_library_sources_ifdef(CONFIG_POSIX_CLOCK_SELECTION clock_selection.c)
endif()
if (NOT CONFIG_TC_PROVIDES_POSIX_C_LIB_EXT)
@ -124,7 +121,6 @@ endif() @@ -124,7 +121,6 @@ endif()
if (NOT CONFIG_TC_PROVIDES_POSIX_TIMERS)
zephyr_library_sources_ifdef(CONFIG_POSIX_TIMERS
clock.c
clock_common.c
timer.c
timespec_to_timeout.c
)
@ -166,7 +162,6 @@ zephyr_library_sources_ifdef(CONFIG_XOPEN_STREAMS stropts.c) @@ -166,7 +162,6 @@ zephyr_library_sources_ifdef(CONFIG_XOPEN_STREAMS stropts.c)
if (NOT CONFIG_TC_PROVIDES_XSI_SINGLE_PROCESS)
zephyr_library_sources_ifdef(CONFIG_XSI_SINGLE_PROCESS
clock_common.c
env_common.c
xsi_single_process.c
)

44
lib/posix/options/clock.c

@ -8,18 +8,23 @@ @@ -8,18 +8,23 @@
#include <errno.h>
#include <time.h>
#include <zephyr/posix/time.h>
#include <zephyr/kernel.h>
#include <zephyr/posix/sys/time.h>
#include <zephyr/posix/time.h>
#include <zephyr/posix/unistd.h>
extern int z_clock_nanosleep(clockid_t clock_id, int flags, const struct timespec *rqtp,
struct timespec *rmtp);
extern int z_clock_gettime(clockid_t clock_id, struct timespec *ts);
extern int z_clock_settime(clockid_t clock_id, const struct timespec *tp);
#include <zephyr/sys/clock.h>
int clock_gettime(clockid_t clock_id, struct timespec *ts)
{
return z_clock_gettime(clock_id, ts);
int ret;
ret = sys_clock_gettime((int)clock_id, ts);
if (ret < 0) {
errno = -ret;
return -1;
}
return 0;
}
int clock_getres(clockid_t clock_id, struct timespec *res)
@ -54,7 +59,15 @@ int clock_getres(clockid_t clock_id, struct timespec *res) @@ -54,7 +59,15 @@ int clock_getres(clockid_t clock_id, struct timespec *res)
*/
int clock_settime(clockid_t clock_id, const struct timespec *tp)
{
return z_clock_settime(clock_id, tp);
int ret;
ret = sys_clock_settime((int)clock_id, tp);
if (ret < 0) {
errno = -ret;
return -1;
}
return 0;
}
/*
@ -88,7 +101,20 @@ int usleep(useconds_t useconds) @@ -88,7 +101,20 @@ int usleep(useconds_t useconds)
int nanosleep(const struct timespec *rqtp, struct timespec *rmtp)
{
return z_clock_nanosleep(CLOCK_MONOTONIC, 0, rqtp, rmtp);
int ret;
if (rqtp == NULL) {
errno = EFAULT;
return -1;
}
ret = sys_clock_nanosleep(SYS_CLOCK_REALTIME, 0, rqtp, rmtp);
if (ret < 0) {
errno = -ret;
return -1;
}
return 0;
}
int clock_getcpuclockid(pid_t pid, clockid_t *clock_id)

204
lib/posix/options/clock_common.c

@ -1,204 +0,0 @@ @@ -1,204 +0,0 @@
/*
* Copyright (c) 2018 Intel Corporation
* Copyright (c) 2018 Friedt Professional Engineering Services, Inc
* Copyright (c) 2025 Tenstorrent AI ULC
*
* SPDX-License-Identifier: Apache-2.0
*/
#include "posix_clock.h"
#include <zephyr/kernel.h>
#include <errno.h>
#include <zephyr/posix/time.h>
#include <zephyr/posix/sys/time.h>
#include <zephyr/posix/unistd.h>
#include <zephyr/internal/syscall_handler.h>
#include <zephyr/sys/sem.h>
#include <zephyr/sys/timeutil.h>
/*
* `k_uptime_get` returns a timestamp based on an always increasing
* value from the system start. To support the `CLOCK_REALTIME`
* clock, this `rt_clock_base` records the time that the system was
* started. This can either be set via 'clock_settime', or could be
* set from a real time clock, if such hardware is present.
*/
static struct timespec rt_clock_base;
static SYS_SEM_DEFINE(rt_clock_base_lock, 1, 1);
int z_impl___posix_clock_get_base(clockid_t clock_id, struct timespec *base)
{
switch (clock_id) {
case CLOCK_MONOTONIC:
base->tv_sec = 0;
base->tv_nsec = 0;
break;
case CLOCK_REALTIME:
SYS_SEM_LOCK(&rt_clock_base_lock) {
*base = rt_clock_base;
}
break;
default:
errno = EINVAL;
return -1;
}
return 0;
}
#ifdef CONFIG_USERSPACE
int z_vrfy___posix_clock_get_base(clockid_t clock_id, struct timespec *ts)
{
K_OOPS(K_SYSCALL_MEMORY_WRITE(ts, sizeof(*ts)));
return z_impl___posix_clock_get_base(clock_id, ts);
}
#include <zephyr/syscalls/__posix_clock_get_base_mrsh.c>
#endif
int z_clock_gettime(clockid_t clock_id, struct timespec *ts)
{
struct timespec base = {.tv_sec = 0, .tv_nsec = 0};
switch (clock_id) {
case CLOCK_MONOTONIC:
break;
case CLOCK_REALTIME:
(void)__posix_clock_get_base(clock_id, &base);
break;
default:
errno = EINVAL;
return -1;
}
uint64_t ticks = k_uptime_ticks();
uint64_t elapsed_secs = ticks / CONFIG_SYS_CLOCK_TICKS_PER_SEC;
uint64_t nremainder = ticks - elapsed_secs * CONFIG_SYS_CLOCK_TICKS_PER_SEC;
ts->tv_sec = (time_t)elapsed_secs;
/* For ns 32 bit conversion can be used since its smaller than 1sec. */
ts->tv_nsec = (int32_t)k_ticks_to_ns_floor32(nremainder);
if (unlikely(!timespec_normalize(ts)) || unlikely(!timespec_add(ts, &base))) {
errno = EOVERFLOW;
return -1;
}
return 0;
}
int z_clock_settime(clockid_t clock_id, const struct timespec *tp)
{
struct timespec base;
if (clock_id != CLOCK_REALTIME) {
errno = EINVAL;
return -1;
}
if (!timespec_is_valid(tp)) {
errno = EINVAL;
return -1;
}
uint64_t elapsed_nsecs = k_ticks_to_ns_floor64(k_uptime_ticks());
int64_t delta = (int64_t)NSEC_PER_SEC * tp->tv_sec + tp->tv_nsec - elapsed_nsecs;
base.tv_sec = delta / NSEC_PER_SEC;
base.tv_nsec = delta % NSEC_PER_SEC;
if (unlikely(!timespec_normalize(&base))) {
errno = EOVERFLOW;
return -1;
}
SYS_SEM_LOCK(&rt_clock_base_lock) {
rt_clock_base = base;
}
return 0;
}
int z_clock_nanosleep(clockid_t clock_id, int flags, const struct timespec *rqtp,
struct timespec *rmtp)
{
uint64_t ns;
uint64_t us;
uint64_t uptime_ns;
const bool update_rmtp = rmtp != NULL;
if (!((clock_id == CLOCK_REALTIME) || (clock_id == CLOCK_MONOTONIC))) {
errno = EINVAL;
return -1;
}
if (rqtp == NULL) {
errno = EFAULT;
return -1;
}
if ((rqtp->tv_sec < 0) || !timespec_is_valid(rqtp)) {
errno = EINVAL;
return -1;
}
if ((flags & TIMER_ABSTIME) == 0 && unlikely(rqtp->tv_sec >= ULLONG_MAX / NSEC_PER_SEC)) {
ns = rqtp->tv_nsec + NSEC_PER_SEC +
(uint64_t)k_sleep(K_SECONDS(rqtp->tv_sec - 1)) * NSEC_PER_MSEC;
} else {
ns = (uint64_t)rqtp->tv_sec * NSEC_PER_SEC + rqtp->tv_nsec;
}
uptime_ns = k_ticks_to_ns_ceil64(sys_clock_tick_get());
if (flags & TIMER_ABSTIME && clock_id == CLOCK_REALTIME) {
SYS_SEM_LOCK(&rt_clock_base_lock) {
ns -= rt_clock_base.tv_sec * NSEC_PER_SEC + rt_clock_base.tv_nsec;
}
}
if ((flags & TIMER_ABSTIME) == 0) {
ns += uptime_ns;
}
if (ns <= uptime_ns) {
goto do_rmtp_update;
}
us = DIV_ROUND_UP(ns, NSEC_PER_USEC);
do {
us = k_sleep(K_TIMEOUT_ABS_US(us)) * 1000;
} while (us != 0);
do_rmtp_update:
if (update_rmtp) {
rmtp->tv_sec = 0;
rmtp->tv_nsec = 0;
}
return 0;
}
#ifdef CONFIG_ZTEST
#include <zephyr/ztest.h>
static void reset_clock_base(void)
{
SYS_SEM_LOCK(&rt_clock_base_lock) {
rt_clock_base = (struct timespec){0};
}
}
static void clock_base_reset_rule_after(const struct ztest_unit_test *test, void *data)
{
ARG_UNUSED(test);
ARG_UNUSED(data);
reset_clock_base();
}
ZTEST_RULE(clock_base_reset_rule, NULL, clock_base_reset_rule_after);
#endif /* CONFIG_ZTEST */

21
lib/posix/options/clock_selection.c

@ -13,15 +13,26 @@ @@ -13,15 +13,26 @@
#include <errno.h>
#include <zephyr/posix/time.h>
#include <zephyr/sys/clock.h>
#include <zephyr/toolchain.h>
extern int z_clock_nanosleep(clockid_t clock_id, int flags, const struct timespec *rqtp,
struct timespec *rmtp);
extern int clock_nanosleep(clockid_t clock_id, int flags, const struct timespec *rqtp,
int clock_nanosleep(clockid_t clock_id, int flags, const struct timespec *rqtp,
struct timespec *rmtp)
{
return z_clock_nanosleep(clock_id, flags, rqtp, rmtp);
int ret;
if (rqtp == NULL) {
errno = EFAULT;
return -1;
}
ret = sys_clock_nanosleep((int)clock_id, flags, rqtp, rmtp);
if (ret < 0) {
errno = -ret;
return -1;
}
return 0;
}
int pthread_condattr_getclock(const pthread_condattr_t *ZRESTRICT att,

4
lib/posix/options/posix_clock.h

@ -61,12 +61,8 @@ static inline bool tp_diff_in_range_ns(const struct timespec *a, const struct ti @@ -61,12 +61,8 @@ static inline bool tp_diff_in_range_ns(const struct timespec *a, const struct ti
uint32_t timespec_to_timeoutms(clockid_t clock_id, const struct timespec *abstime);
__syscall int __posix_clock_get_base(clockid_t clock_id, struct timespec *ts);
/** INTERNAL_HIDDEN @endcond */
#include <zephyr/syscalls/posix_clock.h>
#ifdef __cplusplus
}
#endif

10
lib/posix/options/xsi_single_process.c

@ -12,14 +12,15 @@ @@ -12,14 +12,15 @@
#include <time.h>
#include <zephyr/drivers/hwinfo.h>
#include <zephyr/kernel.h>
#include <zephyr/logging/log.h>
#include <zephyr/sys_clock.h>
#include <zephyr/sys/clock.h>
#include <zephyr/toolchain.h>
LOG_MODULE_REGISTER(xsi_single_process, CONFIG_XSI_SINGLE_PROCESS_LOG_LEVEL);
extern int z_setenv(const char *name, const char *val, int overwrite);
extern int z_clock_gettime(clockid_t clockid, struct timespec *tp);
long gethostid(void)
{
@ -46,10 +47,11 @@ int gettimeofday(struct timeval *tv, void *tz) @@ -46,10 +47,11 @@ int gettimeofday(struct timeval *tv, void *tz)
*/
ARG_UNUSED(tz);
res = z_clock_gettime(CLOCK_REALTIME, &ts);
res = sys_clock_gettime(SYS_CLOCK_REALTIME, &ts);
if (res < 0) {
LOG_DBG("%s() failed: %d", "clock_gettime", res);
return res;
LOG_DBG("%s() failed: %d", "sys_clock_gettime", res);
errno = -res;
return -1;
}
tv->tv_sec = ts.tv_sec;

Loading…
Cancel
Save