zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.

bluetooth bluetooth-le embedded embedded-c iot mcu microcontroller real-time rtos zephyr zephyr-rtos zephyros

History

Gerard Marull-Paretas a5fd0d184a init: remove the need for a dummy device pointer in SYS_INIT functions The init infrastructure, found in `init.h`, is currently used by: - `SYS_INIT`: to call functions before `main` - `DEVICE_`: to initialize devices They are all sorted according to an initialization level + a priority. `SYS_INIT` calls are really orthogonal to devices, however, the required function signature requires a `const struct device dev` as a first argument. The only reason for that is because the same init machinery is used by devices, so we have something like: ```c struct init_entry { int (init)(const struct device dev); /* only set by DEVICE_, otherwise NULL / const struct device dev; } ``` As a result, we end up with such weird/ugly pattern: ```c static int my_init(const struct device dev) { /* always NULL! add ARG_UNUSED to avoid compiler warning / ARG_UNUSED(dev); ... } ``` This is really a result of poor internals isolation. This patch proposes a to make init entries more flexible so that they can accept sytem initialization calls like this: ```c static int my_init(void) { ... } ``` This is achieved using a union: ```c union init_function { / for SYS_INIT, used when init_entry.dev == NULL / int (sys)(void); /* for DEVICE, used when init_entry.dev != NULL / int (dev)(const struct device dev); }; struct init_entry { /* stores init function (either for SYS_INIT or DEVICE) union init_function init_fn; / stores device pointer for DEVICE, NULL for SYS_INIT. Allows to know which union entry to call. / const struct device dev; } ``` This solution does not increase ROM usage, and allows to offer clean public APIs for both SYS_INIT and DEVICE. Note that however, init machinery keeps a coupling with devices. NOTE: This is a breaking change! All `SYS_INIT` functions will need to be converted to the new signature. See the script offered in the following commit. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no> init: convert SYS_INIT functions to the new signature Conversion scripted using scripts/utils/migrate_sys_init.py. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no> manifest: update projects for SYS_INIT changes Update modules with updated SYS_INIT calls: - hal_ti - lvgl - sof - TraceRecorderSource Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no> tests: devicetree: devices: adjust test Adjust test according to the recently introduced SYS_INIT infrastructure. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no> tests: kernel: threads: adjust SYS_INIT call Adjust to the new signature: int (init_fn)(void); Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>		2 years ago
..
CMakeLists.txt	…
CO_driver.c	init: remove the need for a dummy device pointer in SYS_INIT functions	2 years ago
CO_driver_target.h	modules: canopennode: process rx buffers in priority order	2 years ago
Kconfig	crc: Make the build of crc function dependent on a Kconfig	3 years ago
canopen_leds.c	…
canopen_program.c	modules: canopennode: Switch to FIXED_PARTITION_ macros	3 years ago
canopen_storage.c	modules: canopennode: storage: fix size_t format specifier	3 years ago
canopen_sync.c	…
canopennode.h	…