zephyr

Commit Graph

Author	SHA1	Message	Date
Maureen Helm	ad1450510a	drivers: serial: Refactor drivers to use shared init priority Kconfig Refactors all of the serial drivers to use a shared driver class initialization priority configuration, CONFIG_SERIAL_INIT_PRIORITY, to allow configuring serial drivers separately from other devices. This is similar to other driver classes like I2C and SPI. The default is set to CONFIG_KERNEL_INIT_PRIORITY_DEVICE to preserve the existing default initialization priority for most drivers. The one exception is uart_lpc11u6x.c which previously used CONFIG_KERNEL_INIT_PRIORITY_OBJECTS. This change was motivated by an issue on the frdm_k64f board where the serial driver was incorrectly initialized before the clock control driver. Signed-off-by: Maureen Helm <maureen.helm@intel.com>	4 years ago
Gerard Marull-Paretas	a4081b66d8	drivers: serial: remove usage of device_pm_control_nop device_pm_control_nop is now deprecated in favour of NULL. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>	4 years ago
Volodymyr Babchuk	4fb1ee771a	drivers: pl011: add SBSA mode ARM Server Base System Architecture defines Generic UART interface, which is subset of PL011 UART. Minimal SBSA UART implementation does not define UART hardware configuration registers. Basically, only FIFOs and interrupt management operation are defined. Add SBSA mode to PL011 UART driver, so it can be used at SBSA-compatible platforms, like Xen guest. Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>	5 years ago
Kumar Gala	c49b162214	drivers: uart: Convert drivers to new DT device macros Convert uart drivers from: DEVICE_AND_API_INIT -> DEVICE_DT_INST_DEFINE DEVICE_GET -> DEVICE_DT_INST_GET DEVICE_DECLARE -> DEVICE_DT_INST_DECLARE etc.. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Tomasz Bursztyka	4dcfb5531c	isr: Normalize usage of device instance through ISR The goal of this patch is to replace the 'void ' parameter by 'struct device ' if they use such variable or just 'const void ' on all relevant ISRs This will avoid not-so-nice const qualifier tweaks when device instances will be constant. Note that only the ISR passed to IRQ_CONNECT are of interest here. In order to do so, the script fix_isr.py below is necessary: from pathlib import Path import subprocess import pickle import mmap import sys import re import os cocci_template = """ @r_fix_isr_0 @ type ret_type; identifier P; identifier D; @@ -ret_type <!fn!>(void P) +ret_type <!fn!>(const struct device P) { ... ( const struct device D = (const struct device )P; \| const struct device D = P; ) ... } @r_fix_isr_1 @ type ret_type; identifier P; identifier D; @@ -ret_type <!fn!>(void P) +ret_type <!fn!>(const struct device P) { ... const struct device D; ... ( D = (const struct device )P; \| D = P; ) ... } @r_fix_isr_2 @ type ret_type; identifier A; @@ -ret_type <!fn!>(void A) +ret_type <!fn!>(const void A) { ... } @r_fix_isr_3 @ const struct device D; @@ -<!fn!>((void )D); +<!fn!>(D); @r_fix_isr_4 @ type ret_type; identifier D; identifier P; @@ -ret_type <!fn!>(const struct device P) +ret_type <!fn!>(const struct device D) { ... ( -const struct device D = (const struct device )P; \| -const struct device D = P; ) ... } @r_fix_isr_5 @ type ret_type; identifier D; identifier P; @@ -ret_type <!fn!>(const struct device P) +ret_type <!fn!>(const struct device D) { ... -const struct device D; ... ( -D = (const struct device *)P; \| -D = P; ) ... } """ def find_isr(fn): db = [] data = None start = 0 try: with open(fn, 'r+') as f: data = str(mmap.mmap(f.fileno(), 0).read()) except Exception as e: return db while True: isr = "" irq = data.find('IRQ_CONNECT', start) while irq > -1: p = 1 arg = 1 p_o = data.find('(', irq) if p_o < 0: irq = -1 break; pos = p_o + 1 while p > 0: if data[pos] == ')': p -= 1 elif data[pos] == '(': p += 1 elif data[pos] == ',' and p == 1: arg += 1 if arg == 3: isr += data[pos] pos += 1 isr = isr.strip(',\\n\\t ') if isr not in db and len(isr) > 0: db.append(isr) start = pos break if irq < 0: break return db def patch_isr(fn, isr_list): if len(isr_list) <= 0: return for isr in isr_list: tmplt = cocci_template.replace('<!fn!>', isr) with open('/tmp/isr_fix.cocci', 'w') as f: f.write(tmplt) cmd = ['spatch', '--sp-file', '/tmp/isr_fix.cocci', '--in-place', fn] subprocess.run(cmd) def process_files(path): if path.is_file() and path.suffix in ['.h', '.c']: p = str(path.parent) + '/' + path.name isr_list = find_isr(p) patch_isr(p, isr_list) elif path.is_dir(): for p in path.iterdir(): process_files(p) if len(sys.argv) < 2: print("You need to provide a dir/file path") sys.exit(1) process_files(Path(sys.argv[1])) And is run: ./fix_isr.py <zephyr root directory> Finally, some files needed manual fixes such. Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	e18fcbba5a	device: Const-ify all device driver instance pointers Now that device_api attribute is unmodified at runtime, as well as all the other attributes, it is possible to switch all device driver instance to be constant. A coccinelle rule is used for this: @r_const_dev_1 disable optional_qualifier @ @@ -struct device * +const struct device * @r_const_dev_2 disable optional_qualifier @ @@ -struct device * const +const struct device * Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	98d9b01322	device: Apply driver_api/data attributes rename everywhere Via coccinelle: @r_device_driver_api_and_data_1@ struct device *D; @@ ( D-> - driver_api + api \| D-> - driver_data + data ) @r_device_driver_api_and_data_2@ expression E; @@ ( net_if_get_device(E)-> - driver_api + api \| net_if_get_device(E)-> - driver_data + data ) And grep/sed rules for macros: git grep -rlz 'dev)->driver_data' \| xargs -0 sed -i 's/dev)->driver_data/dev)->data/g' git grep -rlz 'dev->driver_data' \| xargs -0 sed -i 's/dev->driver_data/dev->data/g' git grep -rlz 'device->driver_data' \| xargs -0 sed -i 's/device->driver_data/device->data/g' Fixes #27397 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	af6140cc0d	device: Apply config_info rename everywhere Via coccinelle: @r_device_config@ struct device *D; @@ D-> - config_info + config And 2 grep/sed rules for macros: git grep -rlz 'dev)->config_info' \| xargs -0 sed -i 's/dev)->config_info/dev)->config/g' git grep -rlz 'dev->config_info' \| xargs -0 sed -i 's/dev->config_info/dev->config/g' Fixes #27397 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	04d6d0b120	drivers: serial: Fix uart_irq_callback_user_data_t usage Now providing the device pointer that calls the callback. Fixes #26923 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Kumar Gala	a1b77fd589	zephyr: replace zephyr integer types with C99 types git grep -l 'u\(8\\|16\\|32\\|64\)_t' \| \ xargs sed -i "s/u\(8\\|16\\|32\\|64\)_t/uint\1_t/g" git grep -l 's\(8\\|16\\|32\\|64\)_t' \| \ xargs sed -i "s/s\(8\\|16\\|32\\|64\)_t/int\1_t/g" Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Tomasz Bursztyka	97326c0445	device: Fix structure attributes access Since struct devconfig was merged earlier into struct device, let's fix accessing config_info, name, ... attributes everywhere via: grep -rlZ 'dev->config->' \| xargs -0 sed -i 's/dev->config->/dev->/g' Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Kumar Gala	ff1eb62864	drivers: arm_cmsdk/arm: Convert drivers to new DT_INST macros Convert older DT_INST_ macro use in arm_cmsdk/arm drivers to the new include/devicetree.h DT_INST macro APIs. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Kumar Gala	9ede3c9a97	drivers: serial: uart_pl011: remove shared irq support The shared irq support isn't needed in this driver. We just need to deal with the fact that some SoCs have only a single interrupt line and some have three interrupts. We can just ifdef that based on DT_NUM_IRQS. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Kumar Gala	a288f07126	drivers: serial: uart_pl011: Unify uart clock from DT Add a fixed clock to the qemu-virt-a53.dtsi to match how the musca dts files work so we get the clock DT info in the same way in the driver. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Kumar Gala	8bf05c7d61	drivers: serial: pl011: Fix typo bug in port1 support In the DT_INST conversion we introduced a typo bug of accessing port0 instead of port1 in the IRQ config function. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Kumar Gala	aa98c7ba17	drivers: serial: pl011: convert to DT_INST defines Convert driver to use DT_INST_ defines. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Carlo Caione	b9fc192779	drivers: uart_pl011: Enable shared interrupts support The PrimeCell UART (PL011) IP can use one single combined/shared interrupt line instead than different IRQ lines for TX/RX/Err/... This is the most common configuration supported in the Linux world but not currently supported in Zephyr. QEMU emulates a PL011 UART with a single interrupt line as well. To support this configuration we have to hookup the PL011 driver with a shared IRQ driver and add two new configuration options when the shared IRQ line is used. Signed-off-by: Carlo Caione <ccaione@baylibre.com>	6 years ago
Carlo Caione	6148b5bd9e	drivers: uart_pl011: Fix unused variable warning Fix GCC complain when CONFIG_UART_INTERRUPT_DRIVEN=n warning: unused variable ‘config’ [-Wunused-variable] Signed-off-by: Carlo Caione <ccaione@baylibre.com>	6 years ago
Carlo Caione	26ff7603f1	drivers: uart_pl011: Fix compilation when CONFIG_UART_INTERRUPT_DRIVEN=n The driver fails to compile when CONFIG_UART_INTERRUPT_DRIVEN=n. This is due to a nested ifdef on CONFIG_UART_INTERRUPT_DRIVEN that is excluding pieces of code unrelated to the uart interrupts management. Signed-off-by: Carlo Caione <ccaione@baylibre.com>	6 years ago
Carlo Caione	a76a74c541	drivers: uart_pl011: Remove cortex_m header The PL011 driver is not specific to the cortex_m arch and the driver does not really use anything from the cmsis header file. Remove it. Signed-off-by: Carlo Caione <ccaione@baylibre.com>	6 years ago
Piotr Zięcik	60314555ef	drivers: uart_pl011: Get clock frequency from DTS The uart_pl011 driver used system clock frequency as a base for baudrate calculation. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <piotr.ziecik@nordicsemi.no>	6 years ago
Anas Nashif	d1b2718687	cleanup: include/: move uart.h to drivers/uart.h move uart.h to drivers/uart.h and create a shim for backward-compatibility. No functional changes to the headers. A warning in the shim can be controlled with CONFIG_COMPAT_INCLUDES. Related to #16539 Signed-off-by: Anas Nashif <anas.nashif@intel.com>	6 years ago
Patrik Flykt	21358baa72	all: Update unsigend 'U' suffix due to multiplication As the multiplication rule is updated, new unsigned suffixes are added in the code. Signed-off-by: Patrik Flykt <patrik.flykt@intel.com>	6 years ago
Patrik Flykt	24d71431e9	all: Add 'U' suffix when using unsigned variables Add a 'U' suffix to values when computing and comparing against unsigned variables. Signed-off-by: Patrik Flykt <patrik.flykt@intel.com>	6 years ago
Andy Gross	89fb37b76a	uart: pl011: Use correct masking for ICR This patch changes the ICR masking to use a fixed mask instead of a buggy read/write of the current ICR to itself. The ICR is write only and reading this for information is unpredictable and should be avoided. Signed-off-by: Andy Gross <andy.gross@linaro.org>	6 years ago
Andy Gross	9cc4b59069	serial: Add Support for ARM PL011 UART This patch adds a serial driver for the ARM PL011 IP block. Signed-off-by: Andy Gross <andy.gross@linaro.org> Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	7 years ago

26 Commits (ca10f8b0a09d94c46d9561dcd083e66c20fd0f41)