zephyr

Commit Graph

Author	SHA1	Message	Date
Maureen Helm	b539699a98	drivers: dma: Refactor drivers to use shared init priority Refactors all of the DMA drivers to use a shared driver class initialization priority configuration, CONFIG_DMA_INIT_PRIORITY, to allow configuring DMA drivers separately from other devices. This is similar to other driver classes like I2C and SPI. Most drivers previously used CONFIG_KERNEL_INIT_PRIORITY_DEFAULT or CONFIG_KERNEL_INIT_PRIORITY_DEVICE, therefore the default for this new option is the lower of the two, which means earlier initialization. Signed-off-by: Maureen Helm <maureen.helm@intel.com>	4 years ago
Ron Smith	4f9ac180b4	drivers: dma: dma_sam0: change sam0 DMA to higher priority init. fixes peripheral drivers such as async uart that rely on dma being ready failing because dma is not initialized yet. Signed-off-by: Ron Smith <rockyowl171@gmail.com>	4 years ago
Gerard Marull-Paretas	861eac31b8	drivers: dma: remove usage of device_pm_control_nop device_pm_control_nop is now deprecated in favour of NULL. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>	4 years ago
Kumar Gala	02703e60d9	device: Remove DEVICE_DT_DECLARE / DEVICE_DT_INST_DECLARE Now that we generate a header that extern's all possible devicetree based device struct we can remove DEVICE_DT_DECLARE and DEVICE_DT_INST_DECLARE as they aren't needed anymore. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Kumar Gala	c5582358f6	drivers: dma: Convert drivers to new DT device macros Convert dma drivers from: DEVICE_AND_API_INIT -> DEVICE_DT_INST_DEFINE DEVICE_GET -> DEVICE_DT_INST_GET DEVICE_DECLARE -> DEVICE_DT_INST_DECLARE Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Tomasz Bursztyka	4dcfb5531c	isr: Normalize usage of device instance through ISR The goal of this patch is to replace the 'void ' parameter by 'struct device ' if they use such variable or just 'const void ' on all relevant ISRs This will avoid not-so-nice const qualifier tweaks when device instances will be constant. Note that only the ISR passed to IRQ_CONNECT are of interest here. In order to do so, the script fix_isr.py below is necessary: from pathlib import Path import subprocess import pickle import mmap import sys import re import os cocci_template = """ @r_fix_isr_0 @ type ret_type; identifier P; identifier D; @@ -ret_type <!fn!>(void P) +ret_type <!fn!>(const struct device P) { ... ( const struct device D = (const struct device )P; \| const struct device D = P; ) ... } @r_fix_isr_1 @ type ret_type; identifier P; identifier D; @@ -ret_type <!fn!>(void P) +ret_type <!fn!>(const struct device P) { ... const struct device D; ... ( D = (const struct device )P; \| D = P; ) ... } @r_fix_isr_2 @ type ret_type; identifier A; @@ -ret_type <!fn!>(void A) +ret_type <!fn!>(const void A) { ... } @r_fix_isr_3 @ const struct device D; @@ -<!fn!>((void )D); +<!fn!>(D); @r_fix_isr_4 @ type ret_type; identifier D; identifier P; @@ -ret_type <!fn!>(const struct device P) +ret_type <!fn!>(const struct device D) { ... ( -const struct device D = (const struct device )P; \| -const struct device D = P; ) ... } @r_fix_isr_5 @ type ret_type; identifier D; identifier P; @@ -ret_type <!fn!>(const struct device P) +ret_type <!fn!>(const struct device D) { ... -const struct device D; ... ( -D = (const struct device *)P; \| -D = P; ) ... } """ def find_isr(fn): db = [] data = None start = 0 try: with open(fn, 'r+') as f: data = str(mmap.mmap(f.fileno(), 0).read()) except Exception as e: return db while True: isr = "" irq = data.find('IRQ_CONNECT', start) while irq > -1: p = 1 arg = 1 p_o = data.find('(', irq) if p_o < 0: irq = -1 break; pos = p_o + 1 while p > 0: if data[pos] == ')': p -= 1 elif data[pos] == '(': p += 1 elif data[pos] == ',' and p == 1: arg += 1 if arg == 3: isr += data[pos] pos += 1 isr = isr.strip(',\\n\\t ') if isr not in db and len(isr) > 0: db.append(isr) start = pos break if irq < 0: break return db def patch_isr(fn, isr_list): if len(isr_list) <= 0: return for isr in isr_list: tmplt = cocci_template.replace('<!fn!>', isr) with open('/tmp/isr_fix.cocci', 'w') as f: f.write(tmplt) cmd = ['spatch', '--sp-file', '/tmp/isr_fix.cocci', '--in-place', fn] subprocess.run(cmd) def process_files(path): if path.is_file() and path.suffix in ['.h', '.c']: p = str(path.parent) + '/' + path.name isr_list = find_isr(p) patch_isr(p, isr_list) elif path.is_dir(): for p in path.iterdir(): process_files(p) if len(sys.argv) < 2: print("You need to provide a dir/file path") sys.exit(1) process_files(Path(sys.argv[1])) And is run: ./fix_isr.py <zephyr root directory> Finally, some files needed manual fixes such. Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	e18fcbba5a	device: Const-ify all device driver instance pointers Now that device_api attribute is unmodified at runtime, as well as all the other attributes, it is possible to switch all device driver instance to be constant. A coccinelle rule is used for this: @r_const_dev_1 disable optional_qualifier @ @@ -struct device * +const struct device * @r_const_dev_2 disable optional_qualifier @ @@ -struct device * const +const struct device * Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	98d9b01322	device: Apply driver_api/data attributes rename everywhere Via coccinelle: @r_device_driver_api_and_data_1@ struct device *D; @@ ( D-> - driver_api + api \| D-> - driver_data + data ) @r_device_driver_api_and_data_2@ expression E; @@ ( net_if_get_device(E)-> - driver_api + api \| net_if_get_device(E)-> - driver_data + data ) And grep/sed rules for macros: git grep -rlz 'dev)->driver_data' \| xargs -0 sed -i 's/dev)->driver_data/dev)->data/g' git grep -rlz 'dev->driver_data' \| xargs -0 sed -i 's/dev->driver_data/dev->data/g' git grep -rlz 'device->driver_data' \| xargs -0 sed -i 's/device->driver_data/device->data/g' Fixes #27397 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	1580768fd3	drivers: dma: Align all drivers using user_data for callback s/callback_arg/user_data Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	3a3f10c06e	drivers: dma: Align all drivers using dma_callback_t type No need to re-declare such signature anymore. Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Tomasz Bursztyka	6acee3dcba	drivers: dma: Apply DMA callback change to relevant drivers Now the dma device instance is passed as parameter to the callback. Fixes #26923 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>	5 years ago
Hake Huang	999c59c1ec	dma: add error check on peripheral to peripheral add dma direction check for dma_sam0 Signed-off-by: Hake Huang <hake.huang@oss.nxp.com>	5 years ago
Kumar Gala	a1b77fd589	zephyr: replace zephyr integer types with C99 types git grep -l 'u\(8\\|16\\|32\\|64\)_t' \| \ xargs sed -i "s/u\(8\\|16\\|32\\|64\)_t/uint\1_t/g" git grep -l 's\(8\\|16\\|32\\|64\)_t' \| \ xargs sed -i "s/s\(8\\|16\\|32\\|64\)_t/int\1_t/g" Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Kumar Gala	a58777e251	drivers: dma: atmel_sam0: Convert to use devicetree macros for dma dev Convert to using DT_INST_LABEL() in the dma driver and convert dma users to use the DMA property macros to get the dma controller name. We make the assumption in the drivers that there is a single DMA controller instance. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Stephanos Ioannidis	2a710b1372	Revert "drivers: dma: sam0: fix DMA to peripheral transfer on SAMD5x" This reverts commit `90cc723e65`. Using `DMAC_CHCTRLA_TRIGACT_BLOCK` breaks SERCOM UART peripheral DMA operations (DMA-based asynchronous UART transmit operation only sends the first byte and does not proceed any further). The `DMAC_CHCTRLA_TRIGACT_BURST` with `DMAC_CHCTRLA_BURSTLEN(0)` is a special case utilising the "internal FIFO", according to the datasheet (see DS60001507E; 22.6.2.8), and should always be specified for peripheral data transfer operations. Also it is worth noting that Atmel and other third-party drivers use the aforementioned "internal FIFO" configuration for peripheral data transfers as well. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>	5 years ago
Ioannis Glaropoulos	ba6dc5bc25	drivers: dma: sam0: fix macro definition Fix the definition of DMA_SAM0_IRQ_CONNECT pre-processor directive, so that it calls DT_INST_IRQ_BY_IDX macro instead of DT_INST_IRQ_HAS_IDX macro. Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>	5 years ago
Kumar Gala	28870e7a32	drivers: atmel sam0: Convert atmel sam0 drivers to new DT_INST macros Convert older DT_INST_ macro use in atmel sam0 drivers to the new include/devicetree.h DT_INST macro APIs. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	5 years ago
Benjamin Valentin	90cc723e65	drivers: dma: sam0: fix DMA to peripheral transfer on SAMD5x We need to select TRIGACT_BLOCK for DMA to peripheral to work. Signed-off-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>	6 years ago
Anas Nashif	46a5d1e5cb	cleanup: include/: move dma.h to drivers/dma.h move dma.h to drivers/dma.h and create a shim for backward-compatibility. No functional changes to the headers. A warning in the shim can be controlled with CONFIG_COMPAT_INCLUDES. Related to #16539 Signed-off-by: Anas Nashif <anas.nashif@intel.com>	6 years ago
Derek Hageman	59786b43b3	drivers: sam0: Fix deprecated instance macro usage During conversion in #16815 a few device tree instance macro aliases where missed (probably due to them existing to support future SoCs and so not currently compiled), this fixes their usage. Signed-off-by: Derek Hageman <hageman@inthat.cloud>	6 years ago
Kumar Gala	a2693975d7	dts: Convert from DT_<COMPAT>_<INSTANCE>_<PROP> to DT_INST... Change code from using now deprecated DT_<COMPAT>_<INSTANCE>_<PROP> defines to using DT_INST_<INSTANCE>_<COMPAT>_<PROP>. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>	6 years ago
Derek Hageman	64e02021ee	drivers: dma: sam0: Implement get_status API Implement the get_status DMA API for the SAM0 DMA controller. The busy field is set only when the selected channel is actively transferring data (i.e. both enabled and selected by the arbiter). The direction field is left unset, since that information is not normally retained by the DMA controller. Signed-off-by: Derek Hageman <hageman@inthat.cloud>	6 years ago
Michael Hope	ba21de582b	drivers: dma: Add SAM0 DMAC driver This adds support for the SAM0 DMA Controller (DMAC). Chained transfer are not currently implemented. Tested with tests/drivers/dma/loop_transfer and custom modifications to that test using three parallel reloading channels. Also tested with a trivial program that did memory->serial. Signed-off-by: Michael Hope <mlhx@google.com> [hageman@inthat.cloud: Rebased and updated commit message] Signed-off-by: Derek Hageman <hageman@inthat.cloud>	6 years ago

23 Commits (ca10f8b0a09d94c46d9561dcd083e66c20fd0f41)