Browse Source
This patch addresses the issue of invalid initialization sequence and the use of registers in `dma_config` before the device is fully initialized in the Intel ADSP HDA DMA driver. Changes include: 1. Moving the `intel_adsp_hda_channels_init` call to the `intel_adsp_hda_dma_init` function to ensure that channels are initialized during device initialization. 2. Removing the redundant call to `intel_adsp_hda_channels_init` from the `PM_DEVICE_ACTION_RESUME` case in the `intel_adsp_hda_dma_pm_action` function. These changes ensure that the device and its channels are properly initialized before any DMA configuration is performed, preventing access to hardware registers before the device is ready. **Note:** This is a proposed solution, and a different approach should be considered. Currently, we are accessing registers before the device and power domain are fully powered up. This solution likely works because the DMA is used to load firmware during the boot process, and the necessary power domains are already powered up. Further investigation and a more robust solution are recommended to ensure proper initialization and power management. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>pull/82886/head
1 changed files with 2 additions and 2 deletions
Loading…
Reference in new issue