From 9696765b560fa21f519343fe21faca39e44d7fb0 Mon Sep 17 00:00:00 2001 From: Yong Cong Sin Date: Fri, 20 Jun 2025 15:24:49 +0800 Subject: [PATCH] drivers: syscon: remove unnecessary checks for `dev` pointer The `dev` pointer passed to the implementation should never be `NULL`, remove the checks. Signed-off-by: Yong Cong Sin --- drivers/syscon/syscon.c | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/syscon/syscon.c b/drivers/syscon/syscon.c index b2e621a9516..1d2ce4b1263 100644 --- a/drivers/syscon/syscon.c +++ b/drivers/syscon/syscon.c @@ -29,27 +29,16 @@ struct syscon_generic_data { static int syscon_generic_get_base(const struct device *dev, uintptr_t *addr) { - if (!dev) { - return -ENODEV; - } - *addr = DEVICE_MMIO_GET(dev); return 0; } static int syscon_generic_read_reg(const struct device *dev, uint16_t reg, uint32_t *val) { - const struct syscon_generic_config *config; - struct syscon_generic_data *data; + const struct syscon_generic_config *config = dev->config; + struct syscon_generic_data *data = dev->data; uintptr_t base_address; - if (!dev) { - return -ENODEV; - } - - data = dev->data; - config = dev->config; - if (!val) { return -EINVAL; } @@ -79,17 +68,10 @@ static int syscon_generic_read_reg(const struct device *dev, uint16_t reg, uint3 static int syscon_generic_write_reg(const struct device *dev, uint16_t reg, uint32_t val) { - const struct syscon_generic_config *config; - struct syscon_generic_data *data; + const struct syscon_generic_config *config = dev->config; + struct syscon_generic_data *data = dev->data; uintptr_t base_address; - if (!dev) { - return -ENODEV; - } - - data = dev->data; - config = dev->config; - if (syscon_sanitize_reg(®, data->size, config->reg_width)) { return -EINVAL; }