Browse Source

drivers: usb_c: fusb307: Check return value gpio_add_callback()

The result of gpio_add_callback() was not checked, which may
lead to silent failure in alert interrupt setup.

CID: 525074

Signed-off-by: sudarsan N <sudarsansamy2002@gmail.com>
pull/91592/head
sudarsan N 4 weeks ago committed by Benjamin Cabé
parent
commit
357434e908
  1. 7
      drivers/usb_c/tcpc/fusb307.c

7
drivers/usb_c/tcpc/fusb307.c

@ -676,7 +676,12 @@ void fusb307_init_work_cb(struct k_work *work) @@ -676,7 +676,12 @@ void fusb307_init_work_cb(struct k_work *work)
gpio_pin_configure_dt(&cfg->alert_gpio, GPIO_INPUT);
gpio_init_callback(&data->alert_cb, fusb307_alert_cb, BIT(cfg->alert_gpio.pin));
gpio_add_callback(cfg->alert_gpio.port, &data->alert_cb);
ret = gpio_add_callback(cfg->alert_gpio.port, &data->alert_cb);
if (ret < 0) {
LOG_ERR("Failed to add GPIO callback: %d", ret);
return;
}
gpio_pin_interrupt_configure_dt(&cfg->alert_gpio, GPIO_INT_EDGE_TO_ACTIVE);
tcpci_init_alert_mask(data->dev);

Loading…
Cancel
Save