+ Based on https://github.com/ROCm-Developer-Tools/HIP-VS/pull/1298 and https://github.com/ROCm-Developer-Tools/HIP-VS/pull/1300
+ [misc] In the project `hello_world`, `IntrinsicFunctions` is left in the `Debug` configuration to be able to call the variadic function `printf`, which is implemented as an intrinsic in AMD backend
[Synopsis]
+ [nvcc] Before the above changes, `IntrinsicFunctions` was not set to `true` by default
+ [clang] Before the above changes, `IntrinsicFunctions` was set to `true` by default, but wasn't implemented (greyed and unused)
[Reasons]
+ For MS VC++ projects, `IntrinsicFunctions` is set to `true` by default in `Release` configurations (and not set (`false`) in `Debug` configurations)
+ Since implementing the mapping of MS `-Oi` to clang's `-fbuiltin, -fno-builtin`, `IntrinsicFunctions` is supported by both toolsets, thus should be set to `true` by default
+ Based on https://github.com/ROCm-Developer-Tools/HIP-VS/pull/1297
+ Keep `WholeProgramOptimization` for `HIP nvcc` toolsets (`Release` configuration) only
[Reasons]
+ WholeProgramOptimization is not supported in `HIP clang` yet due to the lack of a corresponding clang option
+ Not to mislead the users, because, currently, `WholeProgramOptimization`, even being disabled, still shows that the option is switched on (by the parental `cl` toolset)
[Reason]
+ Despite the project being marked as `ProjectExcludedFromBuild` for `HIP_nvcc`, it doesn't affect `CustomBuild` steps - thus; as a result, the project is still being built for `HIP_nvcc`
[Reasons]
+ `$(LatestTargetPlatformVersion)` is already a default value for both Platform Toolsets `HIP_clang` and `HIP_nvcc`
+ Better to have the latest Windows SDK version for the already created projects when Windows SDK is updated
+ Backward compatibility: Visual Studio 2017 users, for instance, may have Windows SDK < 10.0
[Reason]
+ `AMD.HIP.Clang|Nvcc.Common.props` and `AMD.HIP.Clang|Nvcc.Common.targets` are loaded unconditionally now by HIP-VS Extension
+ The corresponding changes are already implemented in HIP-VS Extension and corresponding project Templates
[IMP]
+ The removed conditions won't appear in `vcxproj` files of newly created (by `Create new Project` Wizard) HIP projects anymore
+ The existing projects still need cleanup
* Resolve "hipBLAS examples are not executed in the CI on Nvidia"
* Resolve "Use chevron launch syntax instead of hipLaunchKernelGGL"
* Resolve "VS2017 and VS2022 files for all examples"
* Resolve "NAVI30 Error occured while hip_module_api sample application is executed"
* Resolve "Enable examples disabled VS"
* Resolve ""hiprtc0504.dll" is missing while running "hip_runtime_compilation_vs2019.exe""
* Resolve "opengl/vulkan: GLFW dependency via GLFW_DIR"
* Resolve "Dedicated ROCm-Examples-VS20xx.sln solution files tagged with "HIP_nvcc" should come with only a selection of examples that can be run on non-AMD hardware."
* Resolve "[EXSWSTRHPC-177] Remove hip_cooperative_groups from sln files"
* PropertyGroup just after ProjectConfigurations ItemGroup
* Literal version numbers instead of MSBuildVersion
* Removed new line at the beginning of solution files
* Changed -Wno-#warnings to --disable-warnings for nvcc in simple_distributions_cpp_vs20XX.vcxproj
---------
Co-authored-by: Nara Prasetya <nara@streamhpc.com>
Co-authored-by: Robin Voetter <robin@streamhpc.com>
* add cmake build instructions for windows
* Add bit extract example
* Resolve "Multi GPU data transfer example"
* Resolve "Vulkan interop example"
* fix bit extract typo
* Resolve "OpenGL interop example"
* Add module API example
* enable -Wall -Wextra -Werror in cmake in ci
* Resolve "CMake don't throw error when building examples and certain libraries are missing."
* Device Globals example
* add moving average example
* Resolve "Static library example"
* fix missing opengl cmake check
* Resolve "Inline assembly / GPU arch example"
* revert to old msvc project file structure
* add hip basic texture management example
* normalize line endings
* remove hiprtc from bitextract
* Resolve "Cooperative groups example"
* Fix GUIDs
* Resolve "Floyd-Warshall example"
Co-authored-by: Nol Moonen <nol@streamhpc.com>
Co-authored-by: Beatriz Navidad Vilches <beatriz@streamhpc.com>
Co-authored-by: Robin Voetter <robin@streamhpc.com>
Co-authored-by: Vince van Heertum <vince@streamhpc.com>
* Resolve "Set Occupancy and Stream examples as C++ 17 standard in Windows Visual Studio"
* Resolve "Fix Bug in Makefile of rocThrust vectors, remove_points and saxpy"
* Fixing rebasing mistake in HIP-Basic events
* Resolve "Port the command line parsing of rocRAND example and matrix multiplication to the common cmdparser.hpp"
* Resolve "Bandwidth example"
* Add required vulkan packages to rocm dockerfile
* Fix the build type variable name in the cmake build on windows
* increase CI docker build timeout
* Add required vulkan packages to cuda dockerfile
* fix vs build files for device query, matrix multiplication, device sum
* fix target names in vcxproj
* Runtime compilation example
* Remove gfx90c target from saxpy
* Fix README.md titles and typos in examples
* Shared memory example
* update docker files to rocm 5.3
* Resolve "2D Shuffle example"
* Assembly to Executable
* Resolve "LLVM IR to executable example"
* Reordering some statements
* update copyright of llvm ir to executable/assembly to executable
* Resolve "Upstreaming examples fixes"
Co-authored-by: Bibrak Qamar <bibrak@streamhpc.com>
Co-authored-by: Lőrinc Serfőző <lorinc@streamhpc.com>
Co-authored-by: Gergely Mészáros <gergely@streamhpc.com>
Co-authored-by: Beatriz Navidad Vilches <beatriz@streamhpc.com>
Co-authored-by: Saad Rahim <44449863+saadrahim@users.noreply.github.com>
Robin Voetter
Evgeny Mankov
Beatriz Navidad Vilches
Beatriz Navidad Vilches
Robin Voetter
Mátyás Aradi