Browse Source

Fixed CMake linting

pull/183/head
Beatriz Navidad Vilches 10 months ago committed by MKKnorr
parent
commit
f8cb857491
  1. 6
      Tutorials/reduction/CMakeLists.txt
  2. 14
      Tutorials/reduction/benchmark/CMakeLists.txt
  3. 10
      Tutorials/reduction/example/CMakeLists.txt
  4. 12
      Tutorials/reduction/test/CMakeLists.txt

6
Tutorials/reduction/CMakeLists.txt

@ -32,14 +32,16 @@ if("${GPU_RUNTIME}" STREQUAL "CUDA") @@ -32,14 +32,16 @@ if("${GPU_RUNTIME}" STREQUAL "CUDA")
else()
cmake_minimum_required(VERSION 3.21)
if(WIN32)
message(STATUS "The reduction tutorial is not supported on Windows. Not building.")
message(
STATUS
"The reduction tutorial is not supported on Windows. Not building."
)
return()
endif()
endif()
project(Reduction LANGUAGES CXX)
file(RELATIVE_PATH folder_bin ${CMAKE_SOURCE_DIR} ${CMAKE_CURRENT_SOURCE_DIR})
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin/${folder_bin})

14
Tutorials/reduction/benchmark/CMakeLists.txt

@ -70,18 +70,24 @@ list(APPEND include_dirs "${PROJECT_SOURCE_DIR}") @@ -70,18 +70,24 @@ list(APPEND include_dirs "${PROJECT_SOURCE_DIR}")
if("${GPU_RUNTIME}" STREQUAL "CUDA")
# For examples targeting NVIDIA, include the HIP header directory.
list(APPEND include_dirs "${ROCM_ROOT}/include")
# Some CUDA versions have issues when compiling for C++20 on Windows, check if we are using those
if(WIN32)
find_package(CUDA)
if(CUDA_FOUND)
set(FAULTY_CUDA_VERSION "12.5")
if(CUDA_VERSION VERSION_LESS_EQUAL ${FAULTY_CUDA_VERSION})
message(WARNING "CUDA version ${CUDA_VERSION} has issues when compiling for C++20. Not building reduction benchmarks.")
message(
WARNING
"CUDA version ${CUDA_VERSION} has issues when compiling for C++20. Not building reduction benchmarks."
)
return()
endif()
else()
message(STATUS "CUDA Toolkit not found. Not building reduction benchmarks.")
message(
STATUS
"CUDA Toolkit not found. Not building reduction benchmarks."
)
return()
endif()
endif()
@ -158,7 +164,7 @@ foreach(VER RANGE 0 10) @@ -158,7 +164,7 @@ foreach(VER RANGE 0 10)
${Sources}
PROPERTIES LANGUAGE ${GPU_RUNTIME}
)
SET(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ROCM_ROOT}/cmake)
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ROCM_ROOT}/cmake)
find_package(HIP MODULE REQUIRED)
target_include_directories(
${TargetName}

10
Tutorials/reduction/example/CMakeLists.txt

@ -77,11 +77,17 @@ if("${GPU_RUNTIME}" STREQUAL "CUDA") @@ -77,11 +77,17 @@ if("${GPU_RUNTIME}" STREQUAL "CUDA")
if(CUDA_FOUND)
set(FAULTY_CUDA_VERSION "12.5")
if(CUDA_VERSION VERSION_LESS_EQUAL ${FAULTY_CUDA_VERSION})
message(WARNING "CUDA version ${CUDA_VERSION} has issues when compiling for C++20. Not building reduction examples.")
message(
WARNING
"CUDA version ${CUDA_VERSION} has issues when compiling for C++20. Not building reduction examples."
)
return()
endif()
else()
message(STATUS "CUDA Toolkit not found. Not building reduction examples.")
message(
STATUS
"CUDA Toolkit not found. Not building reduction examples."
)
return()
endif()
endif()

12
Tutorials/reduction/test/CMakeLists.txt

@ -77,11 +77,17 @@ if("${GPU_RUNTIME}" STREQUAL "CUDA") @@ -77,11 +77,17 @@ if("${GPU_RUNTIME}" STREQUAL "CUDA")
if(CUDA_FOUND)
set(FAULTY_CUDA_VERSION "12.5")
if(CUDA_VERSION VERSION_LESS_EQUAL ${FAULTY_CUDA_VERSION})
message(WARNING "CUDA version ${CUDA_VERSION} has issues when compiling for C++20. Not building reduction tests.")
message(
WARNING
"CUDA version ${CUDA_VERSION} has issues when compiling for C++20. Not building reduction tests."
)
return()
endif()
else()
message(STATUS "CUDA Toolkit not found. Not building reduction tests.")
message(
STATUS
"CUDA Toolkit not found. Not building reduction tests."
)
return()
endif()
endif()
@ -179,7 +185,7 @@ foreach(VER RANGE 1 10) @@ -179,7 +185,7 @@ foreach(VER RANGE 1 10)
${Sources}
PROPERTIES LANGUAGE ${GPU_RUNTIME}
)
SET(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ROCM_ROOT}/cmake)
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ROCM_ROOT}/cmake)
find_package(HIP MODULE REQUIRED)
target_include_directories(
${TargetName}

Loading…
Cancel
Save