Browse Source

fix(cmake): don't strip with BUILD_TYPE None (#5392)

Debian builds with None by default and takes care of stripping itself.
This allows building debug symbol packages.
pull/5503/head
Jochen Sprickerhof 5 months ago committed by GitHub
parent
commit
167bb5f271
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 2
      tools/pybind11NewTools.cmake
  2. 2
      tools/pybind11Tools.cmake

2
tools/pybind11NewTools.cmake

@ -307,7 +307,7 @@ function(pybind11_add_module target_name) @@ -307,7 +307,7 @@ function(pybind11_add_module target_name)
if(DEFINED CMAKE_BUILD_TYPE) # see https://github.com/pybind/pybind11/issues/4454
# Use case-insensitive comparison to match the result of $<CONFIG:cfgs>
string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)
if(NOT MSVC AND NOT "${uppercase_CMAKE_BUILD_TYPE}" MATCHES DEBUG|RELWITHDEBINFO)
if(NOT MSVC AND NOT "${uppercase_CMAKE_BUILD_TYPE}" MATCHES DEBUG|RELWITHDEBINFO|NONE)
# Strip unnecessary sections of the binary on Linux/macOS
pybind11_strip(${target_name})
endif()

2
tools/pybind11Tools.cmake

@ -196,7 +196,7 @@ function(pybind11_add_module target_name) @@ -196,7 +196,7 @@ function(pybind11_add_module target_name)
if(DEFINED CMAKE_BUILD_TYPE) # see https://github.com/pybind/pybind11/issues/4454
# Use case-insensitive comparison to match the result of $<CONFIG:cfgs>
string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)
if(NOT MSVC AND NOT "${uppercase_CMAKE_BUILD_TYPE}" MATCHES DEBUG|RELWITHDEBINFO)
if(NOT MSVC AND NOT "${uppercase_CMAKE_BUILD_TYPE}" MATCHES DEBUG|RELWITHDEBINFO|NONE)
pybind11_strip(${target_name})
endif()
endif()

Loading…
Cancel
Save